Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use context.CancelFunc for cancel functions. #223

Closed
hannahhoward opened this issue Sep 24, 2021 · 0 comments · Fixed by #257
Closed

Use context.CancelFunc for cancel functions. #223

hannahhoward opened this issue Sep 24, 2021 · 0 comments · Fixed by #257
Assignees
@masih
Labels
effort/hours Estimated to take one or several hours exp/beginner Can be confidently tackled by newcomers good first issue Good issue for new contributors P2 Medium: Good to have, but can wait until someone steps up

Comments

@hannahhoward
Copy link
Collaborator

Currently we use a blank function.
@hannahhoward hannahhoward added the need/triage Needs initial labeling and prioritization label Sep 24, 2021
@hannahhoward hannahhoward mentioned this issue Sep 24, 2021
Merged
@hannahhoward hannahhoward added effort/hours Estimated to take one or several hours exp/beginner Can be confidently tackled by newcomers good first issue Good issue for new contributors P2 Medium: Good to have, but can wait until someone steps up and removed need/triage Needs initial labeling and prioritization labels Sep 28, 2021
@masih masih self-assigned this Oct 26, 2021
masih added a commit that referenced this issue Oct 26, 2021
@masih
Use context.CancelFunc instead of func()
11d231f 
Where context cancellation function is referenced in struct types use
existing `context.CancelFunc` to represent.

Fixes #223
@masih masih mentioned this issue Oct 26, 2021
Merged
masih added a commit that referenced this issue Oct 26, 2021
@masih
Use context.CancelFunc instead of func() (#257)
b1d455e 
Where context cancellation function is referenced in struct types use
existing `context.CancelFunc` to represent.

Fixes #223
rvagg pushed a commit that referenced this issue Oct 26, 2021
@masih @rvagg
Use context.CancelFunc instead of func() (#257)
31ae4e7 
Where context cancellation function is referenced in struct types use
existing `context.CancelFunc` to represent.

Fixes #223
rvagg pushed a commit that referenced this issue Oct 26, 2021
@masih @rvagg
Use context.CancelFunc instead of func() (#257)
245a7bd 
Where context cancellation function is referenced in struct types use
existing `context.CancelFunc` to represent.

Fixes #223
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@masih masih

Labels
effort/hours Estimated to take one or several hours exp/beginner Can be confidently tackled by newcomers good first issue Good issue for new contributors P2 Medium: Good to have, but can wait until someone steps up
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use context.CancelFunc instead of func() ipfs/go-graphsync
2 participants
@masih @hannahhoward