Pass through linksystem #166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willscott
approved these changes
Aug 2, 2021
|
while the original application (unixfs reification) needs work, this is still a necessary change to get TrustedStore optimization to apply on the requestor side. |
pass through linksystem so node reifier is present
hannahhoward
force-pushed
the
feat/pass-link-system-request-manager
branch
from
eab6642
to
4d8899b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goals
Make any customizations of the linksystem passed to Graphsync apply to the RequestManager (such as NodeReifier) -- this means if UnixFS reification is enabled on both sides you can do a directory path based selector query in Graphsync
Implementation
Pass through the supplied linksystem down through the RequestManager to the underlying traverser.