Protect Libp2p Connections #229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
also uncovered a bug in early cancellations, resolved by using state pattern from requestmanager
hannahhoward
force-pushed
the
feat/hold-connections
branch
from
afbd9d1
to
efc2c7a
Compare
willscott
approved these changes
Sep 29, 2021
graphsync.go
Outdated
| @@ -14,6 +15,10 @@ import ( | |||
| // RequestID is a unique identifier for a GraphSync request. | |||
| type RequestID int32 | |||
|
|
|||
| func (r RequestID) String() string { | |||
| return strconv.Itoa(int(r)) | |||
There was a problem hiding this comment.
is this preferable to fmt.Sprintf("%d", r)?
There was a problem hiding this comment.
should we have a namespace prefix to prevent potential tag collisions?
There was a problem hiding this comment.
yea I like that.
make tag for request IDs unique to graphsync
This was referenced Oct 4, 2021
Merged
marten-seemann
pushed a commit
that referenced
this pull request
Mar 2, 2023
* refactor: simplify graphsync cancel * docs: add lock required comments to graphsync transport * feat: restore wait for complete in graphsync transport * feat: upgrade to graphsync v0.6.8
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goals
Protect libp2p connections in go-graphsync. fix #226
Implementation