Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stats! #246

Merged
merged 2 commits into from
Oct 13, 2021
Merged

Stats! #246

merged 2 commits into from
Oct 13, 2021

Conversation

hannahhoward
Copy link
Collaborator

Goals

Provide some insight into the state of key metrics in go-graphsync

Implementation

  • implement a stats method for the allocator - gathers a few metrics about allocations
  • pull stats from existing Stats methods in PeerTaskQueue

add a method to gather stats on the current state of the allocator
add statistics method that gathers data from task queues and allocators
Copy link
Member

@rvagg rvagg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm but the lack of test coverage for the top level Stats() seems like something to deal with since it's not doing trivial work.

@hannahhoward hannahhoward merged commit 9be42a2 into main Oct 13, 2021
@aschmahmann aschmahmann mentioned this pull request Dec 1, 2021
80 tasks
@mvdan mvdan deleted the feat/stats branch December 15, 2021 14:18
marten-seemann pushed a commit that referenced this pull request Mar 2, 2023
* feat(deps): update go-graphsync v0.8.0

Update to go-graphsync v0.8.0 with go-ipld-prime linksystem branch & trusted store.

* feat(deps): update to unified go-graphsync v0.9.0

Co-authored-by: raulk <raul@protocol.ai>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants