Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Read request from context #381

Merged
merged 2 commits into from
May 31, 2022
Merged

Conversation

hannahhoward
Copy link
Collaborator

Goals

fix #367

  • allows us to avoid a breaking API change
  • Gives the ability for higher level layers to know the request ID AHEAD of calling NewRequest instead of registering an OutgoingRequestHook

Implementation

  • Define a context key for other layers to set when calling Graphsync that allows specifying the request ID in the context
  • if set, use the request ID from context rather than generate a new one.

allow a request id to be set in the context for a request
@hannahhoward hannahhoward requested a review from rvagg May 25, 2022 20:41
@hannahhoward hannahhoward merged commit a868ee9 into main May 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Accept UUIDs from context in new requests
2 participants