Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: MaxLinks for requests #420

Merged
merged 3 commits into from
Apr 22, 2023
Merged

feat: MaxLinks for requests #420

merged 3 commits into from
Apr 22, 2023

Conversation

rvagg
Copy link
Member

@rvagg rvagg commented Apr 4, 2023

Per-request MaxLinks option. Only for requests currently. No tests yet. Further discussions in Lassie, follow-up PR there and in go-data-transfer.

Copy link
Collaborator

@hannahhoward hannahhoward left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally LGTM. Is there any reason we shouldn't support this ALSO on the other side (i.e. IncomingRequestHookActions)?

That way the data transfer PR can be for Pushes too.

@rvagg rvagg marked this pull request as ready for review April 6, 2023 07:48
@rvagg rvagg requested a review from hannahhoward April 6, 2023 07:48
@rvagg
Copy link
Member Author

rvagg commented Apr 6, 2023

Added support for incoming and outgoing hook configuration of MaxLinks. Also added tests.

Copy link
Collaborator

@hannahhoward hannahhoward left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hannahhoward hannahhoward merged commit 1962d22 into main Apr 22, 2023
hannahhoward added a commit to filecoin-project/lassie that referenced this pull request Apr 22, 2023
* feat: use traversal link budget instead of limitstore

Ref: ipfs/go-graphsync#420
Ref: filecoin-project/go-data-transfer#374

* chore(deps): update go-data-transfer v2.0.0-rc7

* style(lint): fix fmt

---------

Co-authored-by: hannahhoward <hannah@hannahhoward.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants