This repository has been archived by the owner on Jun 19, 2023. It is now read-only.
feat: fast-path for PutMany, falling back to Put for single block call #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guseggert
reviewed
Mar 4, 2022
blockstore.go
Outdated
Comment on lines
221
to
223
| for _, b := range blocksList { | ||
| jobs <- b | ||
| } |
There was a problem hiding this comment.
Will this deadlock if e.g. all the workers return an error, and there are more workers than elements in blocksList?
|
@guseggert I removed my second commit adding the parallelism in PutMany to only keep the fast-path for now. I don't have the bandwidth yet to handle the second part, so let's do the low hanging fruit for now. |
guseggert
approved these changes
May 6, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This avoid the batching overhead.
It's for example called in blockservice, regardless of how many blocks are added.