roundup of cleanup fixes #144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned
Stebalien
commented
Feb 19, 2019
| }() | ||
| } | ||
| } else { | ||
| // not using this channel today | ||
| close(errCh) | ||
| } | ||
|
|
||
| defer func() { |
There was a problem hiding this comment.
We really shouldn't be catching panics this way. This only catches panics where the panic value is an error so it's kind of arbitrary anyways.
IIRC, this was added because we had a bunch of races around Close and SetError but those have since been fixed.
Stebalien
commented
Feb 19, 2019
| @@ -184,16 +184,14 @@ var RootCmd = &cmds.Command{ | |||
| PostRun: cmds.PostRunMap{ | |||
| cmds.CLI: func(res cmds.Response, re cmds.ResponseEmitter) error { | |||
| clire := re.(cli.ResponseEmitter) | |||
|
|
|||
| defer re.Close() | |||
There was a problem hiding this comment.
Don't need to do this explicitly anymore. It's up to the executor to close the response emitter.
Stebalien
commented
Feb 19, 2019
| return re.CloseWithError(nil) | ||
| } | ||
|
|
||
| func (re *responseEmitter) CloseWithError(err error) error { |
There was a problem hiding this comment.
IMO, it's easier to read this when all the close logic is in the same function.
|
Also fixes #113. |
magik6k
approved these changes
Feb 19, 2019
* Don't catch panics. We mostly had this to catch issues with the _commands_ library but catching random panics is really not the best idea. Worse, this code was rather arbitrary and only caught panics implementing `error`. * Make sure to wait for the PostRun to finish before returning.
It wasn't a reliable way to determine if the command was "done". We need to wait for run, post-run, etc. to finish first. * Fixes #143 This commit: 1. Removes the exit channel from the CLI response emitter. 2. Adds a `Status()` function to the `cli.ResponseEmitter` as a replacement for (1). 3. Renames `Exit(code)` to `SetStatus(code)`. This new function doesn't immediately _do_ anything other than set the status. 4. Make sure to wait for _everything_ to finish before returning from `cli.Run`.
We inserted these while transitioning to the new API but we've never hit one.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes fixes/cleanups for a bunch of issues I noticed while debugging #143.
Checkout the commit messages for details. The important fix is waiting for the
Executorto finish. before returning fromRun. Not doing this was causing us to close the process beforeRunwas actually finished.