allow header and set header in client #222
Conversation
|
Thank you for submitting this PR!
Getting other community members to do a review would be great help too on complex PRs (you can ask in the chats/forums). If you are unsure about something, just leave us a comment.
We currently aim to provide initial feedback/triaging within two business days. Please keep an eye on any labelling actions, as these will indicate priorities and status of your contribution. |
|
anyone can review this pr? |
|
@hunjixin: are you able to add the test so we can get this merged? |
|
@BigLep have tested |
aschmahmann
added
need/maintainer-input
|
Thanks. We're blocked on finding maintainer review time. It's in the queue though. |
| // ClientWithHeaders specifies the HTTP header for the client. | ||
| func ClientWithHeaders(key, value string) ClientOpt { |
There was a problem hiding this comment.
nit
| // ClientWithHeaders specifies the HTTP header for the client. | |
| func ClientWithHeaders(key, value string) ClientOpt { | |
| // ClientWithHeader adds an HTTP header to the client. | |
| func ClientWithHeader(key, value string) ClientOpt { |
| testClient := s.Client() | ||
| tc.host = s.URL | ||
| r := &cmds.Request{Path: tc.path, Command: &cmds.Command{}, Root: &cmds.Command{}} | ||
| c := NewClient(tc.host, ClientWithHeaders(tc.header, tc.value)).(*client) |
There was a problem hiding this comment.
| c := NewClient(tc.host, ClientWithHeaders(tc.header, tc.value)).(*client) | |
| c := NewClient(tc.host, ClientWithHeader(tc.header, tc.value)).(*client) |
|
Merged in #226 (addressing my review). Thanks! |
need send Authorization header to remote exec cmds.
allow header and support set header value in client