Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

handle both cmdkit.Error and *cmdkit.Error in ChanResponse #66

Merged
merged 2 commits into from
Feb 20, 2018
Merged

handle both cmdkit.Error and *cmdkit.Error in ChanResponse #66

merged 2 commits into from
Feb 20, 2018

Conversation

Stebalien
Copy link
Member

@ghost ghost assigned Stebalien Feb 16, 2018
@ghost ghost added the status/in-progress In progress label Feb 16, 2018
@Stebalien Stebalien mentioned this pull request Feb 16, 2018
Closed
@codecov
Copy link

codecov bot commented Feb 16, 2018 •
edited
Loading

Codecov Report

Merging #66 into master will increase coverage by 0.05%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #66      +/-   ##
==========================================
+ Coverage      44%   44.05%   +0.05%     
==========================================
  Files          23       23              
  Lines        1925     1927       +2     
==========================================
+ Hits          847      849       +2     
  Misses        938      938              
  Partials      140      140
Impacted Files Coverage Δ
chan.go 65.76% <100%> (+0.62%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1114463...eb87e2f. Read the comment docs.

@kevina
Copy link
Contributor

kevina commented Feb 16, 2018

Assuming this fixes the problem we are having this LGTM.

@kevina kevina mentioned this pull request Feb 16, 2018
Closed
@whyrusleeping whyrusleeping merged commit 144000c into master Feb 20, 2018
@whyrusleeping whyrusleeping deleted the fix/ipfs-4683 branch February 20, 2018 19:18
@ghost ghost removed the status/in-progress In progress label Feb 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@whyrusleeping whyrusleeping whyrusleeping approved these changes

Assignees

@Stebalien Stebalien

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

type mismatch panic on ipfs add
3 participants
@Stebalien @kevina @whyrusleeping