Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Jenkinsfile #89

Merged
merged 1 commit into from
Sep 19, 2018
Merged

Create Jenkinsfile #89

merged 1 commit into from
Sep 19, 2018

Conversation

victorb
Copy link
Member

@victorb victorb commented Mar 26, 2018

No description provided.

@ghost ghost assigned victorb Mar 26, 2018
@ghost ghost added the status/in-progress In progress label Mar 26, 2018
@victorb
Copy link
Member Author

victorb commented Mar 26, 2018

Windows test is failing, parse_test.go:487: parsing request for cmd ["stdinenabled"]: expected error %!q(<nil>), got "argument \"a\" is required" to be exact, @djdv might know whats up

@Stebalien
Copy link
Member

Ah. Well, stdin is disabled on windows. We should probably disable that test on windows until we fix it.

@djdv
Copy link
Contributor

djdv commented Apr 9, 2018

@victorbjelkholm
Sorry, I missed this mention.

The current state of stdio on Windows is that it seems to works under every condition except 1, piping from ipfs to ipfs while the daemon is down. Everything else should work, including ipfs|ipfs when the daemon is up.
Example: ipfs/kubo#4808 (comment)

I need to figure out a solution to the local pipe problem before #74 can be merged.

@victorb
Copy link
Member Author

victorb commented Sep 19, 2018

This is passing now, fine to merge?

@Stebalien Stebalien merged commit 678a25a into master Sep 19, 2018
@ghost ghost removed the status/in-progress In progress label Sep 19, 2018
@Stebalien Stebalien deleted the jenkinsfile branch September 19, 2018 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants