This repository has been archived by the owner on Mar 9, 2022. It is now read-only.
feat: add Addresses.AppendAnnounce #135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lidel
suggested changes
Jul 9, 2021
Jorropo
force-pushed
the
feat/append-announces
branch
from
06bf5af
to
6266d71
Compare
lidel
force-pushed
the
feat/append-announces
branch
from
6266d71
to
f197db4
Compare
lidel
approved these changes
Nov 15, 2021
There was a problem hiding this comment.
Rebased, lgtm, ready for merge.
@aschmahmann I'd like to include this in go-ipfs 0.11, so we most likely want to include this in go-ipfs-config 0.18.0
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On the way to fix: ipfs/kubo#7791