Skip to content
This repository has been archived by the owner on Mar 9, 2022. It is now read-only.

add a flag to enable the hole punching service #155

Merged
merged 2 commits into from
Nov 16, 2021
Merged

add a flag to enable the hole punching service #155

merged 2 commits into from
Nov 16, 2021

Conversation

marten-seemann
Copy link
Member

The tricky part of this will be the logic how we enable this:

  • For this release, we enable hole punching if AutoRelay is enabled.
  • For the next release (when the network has an army of relay nodes), we enabled this by default.

lidel
lidel approved these changes Nov 16, 2021
View reviewed changes
Copy link
Member

@lidel lidel left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The config and plan LGTM (added omitempty).
Thanks to Flag type, the default will be defined in go-ipfs sources with WithDefault, and we will flip from false to true in go-ipfs 0.12.

swarm.go Outdated Show resolved Hide resolved
@lidel lidel merged commit 44a3bfa into master Nov 16, 2021
@lidel lidel deleted the hole-punching branch November 16, 2021 10:55
@aschmahmann aschmahmann mentioned this pull request Dec 1, 2021
Closed
80 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@vyzo vyzo vyzo approved these changes

@lidel lidel lidel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@marten-seemann @vyzo @lidel