Skip to content
This repository has been archived by the owner on Mar 29, 2023. It is now read-only.

sync: update CI config files #34

Merged
merged 7 commits into from
Jul 22, 2021
Merged

sync: update CI config files #34

merged 7 commits into from
Jul 22, 2021

Conversation

web3-bot
Copy link
Collaborator

@web3-bot web3-bot commented Jun 2, 2021 •
edited
Loading

Syncing to commit protocol/.github@5f1e050.

@welcome
Copy link

welcome bot commented Jun 2, 2021

Thank you for submitting this PR!
A maintainer will be here shortly to review it.
We are super grateful, but we are also overloaded! Help us by making sure that:

  • The context for this PR is clear, with relevant discussion, decisions
    and stakeholders linked/mentioned.

  • Your contribution itself is clear (code comments, self-review for the
    rest) and in its best form. Follow the code contribution
    guidelines
    if they apply.

Getting other community members to do a review would be great help too on complex PRs (you can ask in the chats/forums). If you are unsure about something, just leave us a comment.
Next steps:

  • A maintainer will triage and assign priority to this PR, commenting on
    any missing things and potentially assigning a reviewer for high
    priority items.

  • The PR gets reviews, discussed and approvals as needed.

  • The PR is merged by maintainers when it has been approved and comments addressed.

We currently aim to provide initial feedback/triaging within two business days. Please keep an eye on any labelling actions, as these will indicate priorities and status of your contribution.
We are very grateful for your contribution!

masih added a commit that referenced this pull request Jul 22, 2021
@masih
Fix test failure on Windows caused by nil sys in mock FileInfo
8246860 
Fix test failure caused by `panic` when checking if a file is hidden in
Windows. The hidden check uses `FileInfo.Sys()`. In tests the object is
a mock and that call returns `nil`. Regardless of mocking, we should
check for `nil` since according to docs that function can return `nil`.

Run `go mod tidy`.

Relates to:
- #34
@masih masih mentioned this pull request Jul 22, 2021
Merged
@masih
Copy link
Member

masih commented Jul 22, 2021

#39 should fix the panic in Windows tests.

masih added 2 commits July 22, 2021 10:27
@masih
Mock FileInfo.Sys() to return nil explicitly
73547d8 
Otherwise, this function call panics on windows.
@masih
Normalize path separator in tests based in OS
ac10fa8 
Use OS specific path separators in tests
@marten-seemann marten-seemann merged commit dffbf27 into master Jul 22, 2021
@masih masih deleted the web3-bot/sync branch July 22, 2021 10:07
@aschmahmann aschmahmann mentioned this pull request Dec 1, 2021
Closed
80 tasks
hacdias pushed a commit to ipfs/boxo that referenced this pull request Jan 11, 2023
@masih
Fix test failure on Windows caused by nil sys in mock FileInfo
b973565 
Fix test failure caused by `panic` when checking if a file is hidden in
Windows. The hidden check uses `FileInfo.Sys()`. In tests the object is
a mock and that call returns `nil`. Regardless of mocking, we should
check for `nil` since according to docs that function can return `nil`.

Run `go mod tidy`.

Relates to:
- ipfs/go-ipfs-files#34


This commit was moved from ipfs/go-ipfs-files@8246860
hacdias pushed a commit to ipfs/boxo that referenced this pull request Jan 11, 2023
@marten-seemann
Merge pull request ipfs/go-ipfs-files#34 from ipfs/web3-bot/sync
1a66dc4 
sync: update CI config files

This commit was moved from ipfs/go-ipfs-files@dffbf27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@web3-bot @masih @marten-seemann