This repository has been archived by the owner on Mar 29, 2023. It is now read-only.
fix: error when TAR has files outside of root #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
Jorropo
reviewed
Nov 7, 2022
|
Thanks @Jorropo! Everything is addressed. |
lidel
changed the title
lidel
approved these changes
Nov 9, 2022
There was a problem hiding this comment.
Thank you, @hacdias!
I believe this library is a good place to protect a wide array of users (not just Kubo) from issues described in ipfs/specs#288.
Hopefully does not impact legitimate use cases:
- I was unable to think about a scenario where this additional validation would introduce regression, but we will also have Kubo 0.17-rc1 to confirm that.
- If there are any issues, we can always add
ipfs get --allow-unsafe-paths(similar toipfs dag put --allow-big-block).
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See ipfs/kubo#9029 and the “Security” section added in IPIP-288 (ipfs/specs#288)
This will affect both
ipfs get [--archive], as well as the new gateway TAR download format./cc @lidel