This repository has been archived by the owner on Mar 29, 2023. It is now read-only.
create implicit directories from multipart requests #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned
Stebalien
commented
Feb 9, 2019
| @@ -22,94 +21,111 @@ const ( | |||
| contentTypeHeader = "Content-Type" | |||
| ) | |||
|
|
|||
| var ErrPartOutsideParent = errors.New("file outside parent dir") | |||
| var ErrPartInChildTree = errors.New("file in child tree") | |||
| type multipartDirectory struct { | |||
There was a problem hiding this comment.
Renamed as we only use this for directories.
| part *multipart.Part | ||
| reader *peekReader | ||
| mediatype string | ||
| type multipartWalker struct { |
There was a problem hiding this comment.
Replaced peakReader with this so we don't have to keep putting the parts back.
| } | ||
| w.consumePart() |
There was a problem hiding this comment.
Maybe we should pass the part into this function? instead of getting it from the walker?
| reader: part, | ||
| abspath: part.Header.Get("abspath"), | ||
| }, nil | ||
| } | ||
|
|
||
| var err error | ||
| f.mediatype, _, err = mime.ParseMediaType(contentType) | ||
| mediatype, _, err := mime.ParseMediaType(contentType) |
There was a problem hiding this comment.
I'm throwing this away as we aren't using it. We can add it back later if we change our minds.
| filename = escaped | ||
| } // if there is a unescape error, just treat the name as unescaped | ||
|
|
||
| return path.Clean("/" + filename) |
There was a problem hiding this comment.
This ensures filenames area always of the same form (makes it easier to work with them).
| } | ||
|
|
||
| func (it *multipartIterator) Err() error { | ||
| if it.err == io.EOF { |
There was a problem hiding this comment.
I'm using this as a "done" signal. Probably not necessary but I'm paranoid.
Also, introduce a multipart walker to simplify some things. fixes #5
magik6k
approved these changes
Feb 11, 2019
| } | ||
|
|
||
| func (it *multipartIterator) Err() error { | ||
| if it.err == io.EOF { |
Co-Authored-By: Stebalien <steven@stebalien.com>
hacdias
pushed a commit
to ipfs/boxo
that referenced
this pull request
Jan 11, 2023
create implicit directories from multipart requests This commit was moved from ipfs/go-ipfs-files@118a00e
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also, introduce a multipart walker to simplify some things.
fixes #5