response: handle late errors

ipfs · Feb 18, 2019 · 139e9e5 · 139e9e5
1 parent 5c96c29
commit 139e9e5
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 5 deletions.
diff --git a/requestbuilder.go b/requestbuilder.go
@@ -103,11 +103,11 @@ func (r *RequestBuilder) Exec(ctx context.Context, res interface{}) error {
 	}
 
 	if res == nil {
-		httpRes.Close()
+		lateErr := httpRes.Close()
 		if httpRes.Error != nil {
 			return httpRes.Error
 		}
-		return nil
+		return lateErr
 	}
 
 	return httpRes.Decode(res)

diff --git a/response.go b/response.go
@@ -39,9 +39,14 @@ type Response struct {
 
 func (r *Response) Close() error {
 	if r.Output != nil {
-		// always drain output (response body)
-		//ioutil.ReadAll(r.Output) // TODO: might not be a good idea in case there is a lot of data
-		return r.Output.Close()
+
+		// always drain output (response body) //TODO: make optional for things like cat
+		_, err1 := io.Copy(ioutil.Discard, r.Output)
+		err2 := r.Output.Close()
+		if err1 != nil {
+			return err1
+		}
+		return err2
 	}
 	return nil
 }