-
Notifications
You must be signed in to change notification settings - Fork 41
Conversation
41f699d
to
3881ea0
Compare
3881ea0
to
df916c7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly just nits at this point. However, this needs more documentation. I'm required by my OKRs to insist on this 😄.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm a bit lost with Decode
. I believe we want to assert that we get exactly one response, right? Or are we trying to decode the final response?
c4121e9
to
adbfda4
Compare
response.go
Outdated
err = nil | ||
} | ||
return err | ||
return json.NewDecoder(r.Output).Decode(dec) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One final (I promise) nit: We should return the close error (could contain a trailing error).
decoder := json.NewDecoder(r.Output)
if err := decoder.Decode(dec); err != nil {
return err
}
return res.Close()
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! LGTM.
(although I'm not sure what's wrong with travis)
8123f58
to
95ce0f3
Compare
🚢 |
Initial implementation This commit was moved from ipfs/go-ipfs-http-client@449b614
Depends on:
Unixfs.Get