gateway: fix --writable flag :| #3206
Conversation
ghost
added
need/review
ghost
force-pushed
the
feat/writable-flag
branch
from
5c38677
to
bb44538
Compare
|
Added a test for |
|
We can defer this to 0.4.4 since the workaround is to simply set Writable=true in the config. I imagine |
| test_kill_ipfs_daemon | ||
|
|
||
| test_launch_ipfs_daemon --writable=false | ||
| test_expect_success "ipfs daemon --writable=false overrides Writable=true config" ' |
There was a problem hiding this comment.
Where do we set the config value to true?
There was a problem hiding this comment.
Good catch, thanks! Moved the call to test_config_ipfs_gateway_writable up a bit
There was a problem hiding this comment.
I'm still not seeing it... Does it happen in one of the test libs?
There was a problem hiding this comment.
Hey I think you might have been viewing the outdated diff -- it happens right there: https://github.com/ipfs/go-ipfs/pull/3206/files#r78514885
(and I filed #3208 for the unrelated test failure)
ghost
force-pushed
the
feat/writable-flag
branch
2 times, most recently
from
4f06f49
to
11121b4
Compare
License: MIT Signed-off-by: Lars Gierth <larsg@systemli.org>
ghost
force-pushed
the
feat/writable-flag
branch
from
11121b4
to
fc8e6de
Compare
|
Okay we're finally green, I filed #3208 for an unrelated failure. |
| if writableOptionFound { | ||
| cfg.Gateway.Writable = writable | ||
| if !writableOptionFound { | ||
| writable = cfg.Gateway.Writable |
There was a problem hiding this comment.
These 4 lines are the essence of the bug.
|
LGTM! |
ghost
mentioned this pull request
gateway: fix --writable flag :| This commit was moved from ipfs/kubo@0aa136a
Broke it in #2874... my unproven assumption apparantly was that
cfg.Gateway.Writable = truewould somehow magically make it into other instances of the config retrieved viaRepo.Config()...We're not overloading the repo config with this anymore now. We also have a test for
--writablenow.