Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TestHasIsBloomCached failures #3208

Closed
ghost opened this issue Sep 11, 2016 · 6 comments
Closed

TestHasIsBloomCached failures #3208

ghost opened this issue Sep 11, 2016 · 6 comments
Labels
help wanted Seeking public contribution on this issue topic/test failure Topic test failure

Comments

@ghost
Copy link

ghost commented Sep 11, 2016

https://travis-ci.org/ipfs/go-ipfs/jobs/159157692

--- FAIL: TestHasIsBloomCached (0.03s)
    bloom_cache_test.go:100: Bloom filter has cache miss rate of more than 5%
FAIL
FAIL    github.com/ipfs/go-ipfs/blocks/blockstore   0.053s
@ghost ghost added the topic/test failure Topic test failure label Sep 11, 2016
@ghost ghost assigned Kubuxu Sep 11, 2016
@ghost ghost mentioned this issue Sep 11, 2016
Merged
@ghost
Copy link
Author

ghost commented Sep 11, 2016

Another, on OSX this time: https://travis-ci.org/ipfs/go-ipfs/jobs/159136318

@Kubuxu
Copy link
Member

Kubuxu commented Sep 12, 2016 •
edited
Loading

After 10000 iterations of that test with race detector and I am unable to replicate this, nither I have any explenation why it failed.

@Kubuxu Kubuxu removed their assignment Sep 12, 2016
@whyrusleeping whyrusleeping added the help wanted Seeking public contribution on this issue label Sep 14, 2016
@flyingzumwalt flyingzumwalt added the status/deferred Conscious decision to pause or backlog label Sep 26, 2016
@Stebalien
Copy link
Member

Saw it again. Isn't just a test bug? Bloom filters are probabilistic (assuming this test isn't supposed to be deterministic...).

@Kubuxu
Copy link
Member

Kubuxu commented Aug 29, 2017

It is test bug. I will change the test to use deterministic seed.

@Kubuxu
Copy link
Member

Kubuxu commented Aug 29, 2017

Hmm, it uses deterministic seed. I have no idea how it failed. Looks like I have the same reaction as I had a year ago. #3208 (comment)

This was referenced Jul 18, 2018
Merged
Closed
@Stebalien
Copy link
Member

Moved to ipfs/go-ipfs-blockstore#6

@ghost ghost removed the status/deferred Conscious decision to pause or backlog label Jul 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted Seeking public contribution on this issue topic/test failure Topic test failure
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@flyingzumwalt @Stebalien @whyrusleeping @Kubuxu