Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Precompute Blob CID, fixes #21 #27

Merged
merged 1 commit into from
Dec 18, 2018
Merged

Precompute Blob CID, fixes #21 #27

merged 1 commit into from
Dec 18, 2018

Conversation

sameer
Copy link
Contributor

@sameer sameer commented Dec 18, 2018

The Blob type is changed to a struct with rawdata and cid members so Blob CIDs can be precomputed in ReadBlob.

Let me know if there are any changes that need to be made, feedback is welcome.

Copy link
Member

@magik6k magik6k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Build fails

blob.go Outdated Show resolved Hide resolved
blob.go Outdated Show resolved Hide resolved
@sameer sameer mentioned this pull request Dec 18, 2018
Copy link
Member

@magik6k magik6k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@magik6k magik6k merged commit 5b2f4a8 into ipfs:master Dec 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants