Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: migrate subdomain and dnslink code #153

Merged
merged 2 commits into from
Feb 7, 2023
Merged

feat: migrate subdomain and dnslink code #153

merged 2 commits into from
Feb 7, 2023

Conversation

hacdias
Copy link
Member

@hacdias hacdias commented Feb 2, 2023

Closes #149.

Some things I want to improve:

Note: sharness expected to fail as we changed the Gateway API interface.

@hacdias hacdias self-assigned this Feb 2, 2023
@codecov
Copy link

codecov bot commented Feb 2, 2023

Codecov Report

Merging #153 (aa8a482) into main (a4e0934) will increase coverage by 1.11%.
The diff coverage is 45.90%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #153      +/-   ##
==========================================
+ Coverage   18.66%   19.77%   +1.11%     
==========================================
  Files          99      100       +1     
  Lines       10540    10968     +428     
==========================================
+ Hits         1967     2169     +202     
- Misses       8294     8512     +218     
- Partials      279      287       +8     
Impacted Files Coverage Δ
examples/gateway/car/main.go 9.83% <0.00%> (-4.80%) ⬇️
examples/gateway/common/blocks.go 38.19% <0.00%> (-2.25%) ⬇️
examples/gateway/proxy/main.go 0.00% <0.00%> (ø)
gateway/gateway.go 0.00% <ø> (ø)
gateway/hostname.go 53.15% <53.15%> (ø)

gateway/hostname.go Outdated Show resolved Hide resolved
gateway/hostname.go Outdated Show resolved Hide resolved
gateway/hostname.go Outdated Show resolved Hide resolved
@hacdias hacdias force-pushed the issue/149 branch 2 times, most recently from 85fcfb8 to c091fd6 Compare February 2, 2023 15:17
gateway/hostname_test.go Outdated Show resolved Hide resolved
@hacdias
Copy link
Member Author

hacdias commented Feb 3, 2023

@lidel I updated the PR and the Kubo PR: ipfs/kubo#9624. Every test is passing now. I'm not very happy how I ended up handling it: I added a new function to the interface. Read more about the issue here: ipfs/kubo#9624 (comment) - I feel like the alternative would require me to do deeper changes to the Hostname code.

gateway/gateway.go Outdated Show resolved Hide resolved
@hacdias hacdias force-pushed the issue/149 branch 2 times, most recently from f96dcbb to 4cb72e4 Compare February 6, 2023 09:37
Copy link
Member

@lidel lidel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @hacdias!

Pushed small doc changes because extracted things lacked context outside Kubo.

Good enough for now, but we will refine the way configuration happens in the future.
(after bifrost-gateway / Kubo 0.19)

@lidel lidel merged commit 1a932f7 into main Feb 7, 2023
@lidel lidel deleted the issue/149 branch February 7, 2023 02:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

gateway: migrate subdomain and dnslink code
2 participants