-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: migrate subdomain and dnslink code #153
Conversation
Codecov Report
@@ Coverage Diff @@
## main #153 +/- ##
==========================================
+ Coverage 18.66% 19.77% +1.11%
==========================================
Files 99 100 +1
Lines 10540 10968 +428
==========================================
+ Hits 1967 2169 +202
- Misses 8294 8512 +218
- Partials 279 287 +8
|
85fcfb8
to
c091fd6
Compare
@lidel I updated the PR and the Kubo PR: ipfs/kubo#9624. Every test is passing now. I'm not very happy how I ended up handling it: I added a new function to the interface. Read more about the issue here: ipfs/kubo#9624 (comment) - I feel like the alternative would require me to do deeper changes to the Hostname code. |
05642b0
to
13b6f58
Compare
f96dcbb
to
4cb72e4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @hacdias!
Pushed small doc changes because extracted things lacked context outside Kubo.
Good enough for now, but we will refine the way configuration happens in the future.
(after bifrost-gateway
/ Kubo 0.19)
Closes #149.
Some things I want to improve:
/api
and/p2p
from hostname and keep in Kubo (related to point before)I'm think it might be caused by us now callingUnlikely. ResolvePath returns the error of namesys.Resolve.ResolvePath
instead ofnamesys.Resolve
. This is because the namesys.Resolve is part of ResolvePath and ResolvePath does more than just namesys.Resolve. So we catch some weird errors here.Note: sharness expected to fail as we changed the Gateway API interface.