Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove syslogger #47

Merged
merged 1 commit into from
Sep 13, 2018
Merged

remove syslogger #47

merged 1 commit into from
Sep 13, 2018

Conversation

frrist
Copy link
Member

@frrist frrist commented Sep 13, 2018

  • fork of op/go-logging doesn't have latest code for windows syslogger
    fallback

Reason: 29c2a5b#commitcomment-30495666
Thank you @DanielSel

- fork of op/go-logging doesn't have latest code for windows syslogger
fallback
@frrist frrist added the kind/bug A bug in existing code (including security flaws) label Sep 13, 2018
@frrist frrist self-assigned this Sep 13, 2018
@ghost ghost added the status/in-progress In progress label Sep 13, 2018
Copy link
Member

@travisperson travisperson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, this hasn't been published yet so I believe we are safe to just remove the feature outright.

@Stebalien Stebalien merged commit f29ae87 into master Sep 13, 2018
@ghost ghost removed the status/in-progress In progress label Sep 13, 2018
@Stebalien Stebalien deleted the fix/syslog-windonts branch September 13, 2018 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug A bug in existing code (including security flaws)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants