Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add environment variable for writing tracing information to a file #52

Merged
merged 1 commit into from
Oct 30, 2018

Conversation

Stebalien
Copy link
Member

No description provided.

@ghost ghost assigned Stebalien Oct 3, 2018
@ghost ghost added the status/in-progress In progress label Oct 3, 2018
@Stebalien Stebalien requested a review from frrist October 3, 2018 23:53
@Stebalien
Copy link
Member Author

@frrist what's the recommended way to view this information?

@frrist
Copy link
Member

frrist commented Oct 4, 2018 via email

@Stebalien
Copy link
Member Author

@frrist tracing, not logging. That is, do you know of a good way to visualize a JSON dump of a trace?

@frrist
Copy link
Member

frrist commented Oct 5, 2018

Woops thought this was a different thing for a moment, sorry about that.

I don't know of any tracers that can analyze tracing data from a file. I think tracers like Jaeger will listen on some port for json representing a trace -- my gut says we could use something like netcat to send the contents of the file to the port Jaeger is listening on.

@Stebalien
Copy link
Member Author

Merging this as there's no reason not to. However, we should look into reworking the logging system.

@Stebalien Stebalien merged commit 4b03637 into master Oct 30, 2018
@ghost ghost removed the status/in-progress In progress label Oct 30, 2018
@Stebalien Stebalien deleted the feat/tracing-file branch October 30, 2018 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants