fix some performance regressions when reading protobuf nodes #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
magik6k
approved these changes
Feb 28, 2019
Kubuxu
approved these changes
Feb 28, 2019
Jorropo
pushed a commit
to ipfs/boxo
that referenced
this pull request
Mar 15, 2023
fix some performance regressions when reading protobuf nodes This commit was moved from ipfs/go-merkledag@de6f1da
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is also a bugfix as we don't want to re-encode nodes unless we change them. If we do and the user chose a non-standard encoding, we could change the CID. This is likely what triggered ipfs/kubo#6011