This repository has been archived by the owner on Jun 20, 2023. It is now read-only.
fix: don't dag.Get in ResolveToLastNode when not needed #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@magik6k could you add a test for this one? |
magik6k
force-pushed
the
fix/resolve-last-cid
branch
from
1a7c329
to
b999913
Compare
magik6k
force-pushed
the
fix/resolve-last-cid
branch
from
b999913
to
29e9e4c
Compare
|
Added some |
Stebalien
added a commit
to ipfs/kubo
that referenced
this pull request
Aug 7, 2018
see: ipfs/go-path#1 License: MIT Signed-off-by: Steven Allen <steven@stebalien.com>
Stebalien
added a commit
to ipfs/kubo
that referenced
this pull request
Aug 7, 2018
see: ipfs/go-path#1 License: MIT Signed-off-by: Steven Allen <steven@stebalien.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently when trying to resolve path that points directly at an 'invalid' block, resolving will fail:
This is a problem for block coreapi - ipfs/kubo#5331 (it works with this patch applied)