When priority is equal, use FIFO #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stebalien
approved these changes
Aug 24, 2021
peertracker/peertracker.go
Outdated
| @@ -59,14 +60,15 @@ type PeerTracker struct { | |||
| } | |||
|
|
|||
| // New creates a new PeerTracker | |||
| func New(target peer.ID, taskMerger TaskMerger, maxActiveWorkPerPeer int) *PeerTracker { | |||
| func New(target peer.ID, taskMerger TaskMerger, maxActiveWorkPerPeer int, clock clock.Clock) *PeerTracker { | |||
There was a problem hiding this comment.
Given that this clock is just for testing... can we use a private global one? Otherwise, it becomes a part of the API.
There was a problem hiding this comment.
yea fair I think.
dirkmc
approved these changes
Aug 24, 2021
Stebalien
approved these changes
Aug 24, 2021
peertracker/peertracker_test.go
Outdated
Comment on lines
579
to
581
| defer func() { | ||
| clockInstance = oldClock | ||
| }() |
There was a problem hiding this comment.
nit: use t.Cleanup to make sure this always runs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goals
I had been assuming in a peer task queue, if I queue tasks for a given peer with equal priority over time, that they will dequeue in FIFO order. As it turns out, this is not the case. This makes me super concerned -- we use this in Graphsync and it's a major bummer if requests don't queue in the order received for a given peer. Not sure the Bitswap implications but I can't imagine they are great.
Implementation
For Discussion
Alternative idea would be to allow custom specification of priority order.