This repository has been archived by the owner on Jun 27, 2023. It is now read-only.
feat(Directory): Add EnumLinksAsync method #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
schomatis
reviewed
Oct 17, 2018
magik6k
reviewed
Oct 17, 2018
io/directory.go
Outdated
| go func() { | ||
| defer close(linkResults) | ||
| for _, l := range d.node.Links() { | ||
| linkResults <- format.LinkResult{ |
There was a problem hiding this comment.
This should also select on ctx to avoid leaking goroutines (same in other places)
There was a problem hiding this comment.
got it. will do.
hannahhoward
force-pushed
the
features/streaming-ls-5600
branch
2 times, most recently
from
cfc13dc
to
6ec34f8
Compare
magik6k
reviewed
Oct 19, 2018
hamt/hamt.go
Outdated
| "github.com/spaolacci/murmur3" | ||
|
|
||
| format "github.com/ipfs/go-unixfs" |
io/directory.go
Outdated
| @@ -141,6 +146,26 @@ func (d *BasicDirectory) AddChild(ctx context.Context, name string, node ipld.No | |||
| return d.node.AddNodeLink(name, node) | |||
| } | |||
|
|
|||
| // EnumLinksAsync returns a channel which will receive Links in the directory | |||
| // as they are enumerated, where order is not gauranteed | |||
| func (d *BasicDirectory) EnumLinksAsync(ctx context.Context) (<-chan format.LinkResult, error) { | |||
There was a problem hiding this comment.
I'd drop the error from the signature since it's not used here (or other impls of this function)
schomatis
reviewed
Oct 29, 2018
schomatis
reviewed
Oct 29, 2018
- Add LinkResult type to unix-fs - is an ipld Link or an error - Add EnumLinksAsync method to Directory interface, returns channel of directory links or error - Add EnumLinksAsync method to Shard interface in HAMT, returns channel of directory links or error - EnumLinks method in Shard interface in HAMT uses EnumLinksAsync now - modify makeAsyncTrieGetLinks to use channel
hannahhoward
force-pushed
the
features/streaming-ls-5600
branch
from
eee76dd
to
c54d0e4
Compare
|
@schomatis are you good with my responses? Can we go ahead and merge this PR? |
schomatis
approved these changes
Oct 30, 2018
magik6k
approved these changes
Oct 30, 2018
|
I think I'm going to go ahead and merge but feel free to continue this discussion. |
Jorropo
pushed a commit
to Jorropo/go-libipfs
that referenced
this pull request
Jan 25, 2023
…5600 feat(Directory): Add EnumLinksAsync method This commit was moved from ipfs/go-unixfs@a3eae7f
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
child of ipfs/kubo#5600
Implement an EnumLinksAsync method on Directory interface to support streaming version of
lscommandImplementation
of directory links or error
For Discussion
lsto go-ipfs