This repository has been archived by the owner on Jun 27, 2023. It is now read-only.
fix(directory): initialize size when computing it #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jorropo
pushed a commit
to Jorropo/go-libipfs
that referenced
this pull request
Jan 25, 2023
…ute-size fix(directory): initialize size when computing it This commit was moved from ipfs/go-unixfs@06053e4
Jorropo
pushed a commit
to ipfs/go-libipfs-rapide
that referenced
this pull request
Mar 23, 2023
…ute-size fix(directory): initialize size when computing it This commit was moved from ipfs/go-unixfs@06053e4
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Normally this is called from the constructor with the size cleared but I added the same call to the unlikely case we underflow because of a bug. Maybe that call shouldn't exist in the first place but wasn't sure how to handle that without leaving the computation unbalanced. In any case, this is not an addition like the other functions but a computation from scratch so this is the right fix.