This repository has been archived by the owner on Jan 8, 2024. It is now read-only.
fix: make @libp2p/interface a dependency #159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should be a dep not a dev dep. Refs #158
achingbrain
added a commit
to ipfs/aegir
that referenced
this pull request
Dec 29, 2023
Runs the dep-check command twice - once omitting dev deps and only checking non-test code, then again but only testing test code. Should prevent future bugs similar to ipfs/helia-ipns#159
achingbrain
added a commit
to ipfs/aegir
that referenced
this pull request
Jan 6, 2024
Runs the dep-check command twice - once omitting dev deps and only checking non-test code, then again but only testing test code. [depcheck](https://www.npmjs.com/package/depcheck) is a bit wonky in that it doesn't support whitelisting files to check, only blacklisting so we pass a configurable list of ignore patterns that exclude known test files while checking prod deps and then a list of known prod files while checking dev deps. Should prevent future bugs similar to ipfs/helia-ipns#159 BREAKING CHANGE: previously undetected missing or unused deps will cause the dep-check command to fail
github-actions bot
pushed a commit
that referenced
this pull request
Jan 8, 2024
## [@helia/ipns-v4.0.0](https://github.com/ipfs/helia-ipns/compare/@helia/ipns-v3.0.1...@helia/ipns-v4.0.0) (2024-01-08) ### ⚠ BREAKING CHANGES * uses multiformats v13 and helia v3, renames `dht` routing to `libp2p` ### Features * update helia to v3 and multiformats to v13 ([#167](#167)) ([a0381b9](a0381b9)) ### Bug Fixes * make @libp2p/interface a dependency ([#159](#159)) ([546ecf0](546ecf0)), closes [#158](#158)
|
🎉 This PR is included in version @helia/ipns-v4.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should be a dep not a dev dep.
Refs #158