fix: all repo compatibility tests

[Stebalien]

We've changed how we name keys in the keystore but the js-ipfs migration isn't quite ready. The real issue here is that the repo versions differ.

[achingbrain]

If unskipped they fail with:

  1) ipns locally using the same repo across implementations
       should publish an ipns record to a js daemon and resolve it using a go daemon through the reuse of the same repo:
     Error: Timeout of 160000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves. (/home/circleci/ipfs/go-ipfs/interop/test/ipns.js)
  

  2) ipns locally using the same repo across implementations
       should publish an ipns record to a go daemon and resolve it using a js daemon through the reuse of the same repo:
     Error: Timeout of 160000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves. (/home/circleci/ipfs/go-ipfs/interop/test/ipns.js)

@vasco-santos any ideas?

[Stebalien]

Go PR: ipfs/kubo#6955

[vasco-santos]

We currently use this format: https://github.com/ipfs/js-ipns/blob/master/src/index.js#L209-L219

I need to try it out and look on go changes, but cannot do it today

[Stebalien]

@vasco-santos we haven't changed the way we're storing IPNS records, we've changed the way we encode key names in the on-disk keystore. As far as I know, that shouldn't affect this test as we're using the identity key (which isn't stored in the keystore, IIRC).

[vasco-santos]

@Stebalien I understood and I think that the problem might be the key name stored in the local datastore. We store locally here the IPNS record, using the datastore key in this format.

For what I understand, the naming should have changed and js-ipfs cannot get it from the datastore, in order to get the IPNS records. I need to check what is going on later to be more accurate

[Stebalien]

I'm lost. We haven't changed anything about IPNS records and/or how we store/name them. We've only changed how we encode the names of private keys.

[hsanjuan]

Isn't the js daemon just failing to start because of the different repo version when using same repo?

[23:11:33] ~/n/.bin $ ./jsipfs daemon
Initializing IPFS daemon...
js-ipfs version: 0.41.2
System version: x64/linux
Node.js version: 12.16.1
Incompatible repo version. Migration needed. Pass --migrate for automatic migration

[Stebalien]

Oh. My bad. That explains it.

[Stebalien]

I've changed this to disable all repo compatibility tests as they all fail now.

[vasco-santos]

LGTM! Seems a good call until js-ipfs updates the repo version👍

[achingbrain]

LGTM, just needs green CI

[achingbrain]

What feature is the repo version bump in go for?

[Stebalien]

1. Fixing the bootstrap peers in the config to remove the 1024bit peers, make sure we have the new 2048bit peers, and replace all instances of /ipfs/ with /p2p/.
2. Encoding keys in the on-disk keystore using base32: feat: encoding key's name to base32 js-ipfs#2410

[hsanjuan]

should this be merged?

[achingbrain]

CI is still failing, that should be resolved before merging

[Stebalien]

The CI issue is unrelated. Force-pushing to rerun.

[Stebalien]

@achingbrain it looks like the firefox circuit tests are failing for unrelated reasons.

[achingbrain]

The firefox circuit tests have been fixed in master by upgrading libp2p-webrtc-star as part of #108 - ref: libp2p/js-libp2p-webrtc-star#212