-
Notifications
You must be signed in to change notification settings - Fork 15
Test imported js-ipfs ipns key pubsub'ing to, and resolving on go-ipfs #136
base: master
Are you sure you want to change the base?
Conversation
Thank you for submitting this PR!
Getting other community members to do a review would be great help too on complex PRs (you can ask in the chats/forums). If you are unsure about something, just leave us a comment.
We currently aim to provide initial feedback/triaging within two business days. Please keep an eye on any labelling actions, as these will indicate priorities and status of your contribution. |
@DougAnderson444 do you mind testing against this branch of go-ipfs to see what happens ipfs/kubo#7549? If you don't have time or are having trouble lmk and I'll get to it when I get a chance. |
I didn't get very far -- tried to |
@aschmahmann I ran this against your branch and things are passing. I did have to make some local fixes to the tests. The tests should get cleaned up before this gets merged. Some of the later tests are dependent on the earlier ones which makes this suite fragile to future updates. It also makes the tests harder to follow. fyi the easiest way to run against a go branch is to build it locally and use the env variable for the path Also, I found a bug in the js http client. Streaming can't be overridden (it's always true) which is giving us some false positives. I'll submit a fix for that. |
@jacobheun great, so I'll merge that branch then. lmk when the updated interop is released and we'll track it in go-ipfs CI. |
94b26b7
to
f4c783a
Compare
e2cb915
to
b006606
Compare
Context
After having issues publishing to
ipns
using an importedkey
injs-ipfs
, then (with pubsub enabled) attempting to resolve thatipns key
ongo-ipfs
, @vasco-santos proposed submitting a PR with failing tests. This is the PR to show where it's failing.Prior Art
This test is based off https://github.com/ipfs/interop/blob/master/test/ipns-pubsub.js#L89-L115
Referenced People and Conversations:
https://discuss.ipfs.io/t/cant-access-published-ipns-record-config-problem/5476/17
https://discuss.ipfs.io/t/ipns-not-resolvable-from-other-node/8624/3
ipfs/kubo#6360
I've been trying to figure this out with @aschmahmann who has been doing great work on the go-side of things, and his upcoming changes may fix this issue. For now, here's the failing test on it.
Failing tests
The test fail:
When the imported key is replaced with 'self' key, everything works fine, as expected.
Other note
I added
"test:node-ipns"
just so I could run this test by itself, left it there for anyone who needs the same functionality while reviewing this test.