Skip to content
This repository has been archived by the owner on Aug 1, 2023. It is now read-only.

chore: update websockets to 0.15 #203

Merged
merged 1 commit into from
Dec 16, 2020
Merged

Conversation

vasco-santos
Copy link
Member

This PR updates websockets usage to 0.15 per libp2p migration v0.29-v0.30.md#development-and-testing.

Local websocket dial from a browser should not be filtered out for testing purposes

Copy link
Member

@achingbrain achingbrain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM.

  1. Do we need libp2p@0.30.0 in js-ipfs before this can be released?
  2. What happened to the package-lock file? 670 additions and 27k deletions?

@vasco-santos vasco-santos force-pushed the chore/update-websockets branch 2 times, most recently from c73c31e to c0fb4f7 Compare December 16, 2020 17:10
@vasco-santos
Copy link
Member Author

Do we need libp2p@0.30.0 in js-ipfs before this can be released?

No, it does not need it! libp2p already supported passing the transport configuration. We just got this together with 0.30 to notice the potential breaking usage if examples/tests use local addresses. Libp2p integration PR in IPFS needs this as it uses the new websockets as well.

What happened to the package-lock file? 670 additions and 27k deletions?

I retried doing it, but the same result. I just installed libp2p-websockets and it auto updated like that.
I think that before it relied on libp2p-websockets via other modules (like IPFS) that have it has dependencies. But now, as we install it in this repo it changed the JSON structure to have the websockets in the top level.

@achingbrain achingbrain merged commit 945e7a6 into master Dec 16, 2020
@achingbrain achingbrain deleted the chore/update-websockets branch December 16, 2020 17:28
@achingbrain
Copy link
Member

I retried doing it, but the same result

What version of node are you running?

@achingbrain
Copy link
Member

Shipped in ipfs-interop@4.0.1 btw

@vasco-santos
Copy link
Member Author

I am with 14.15.2

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants