This repository has been archived by the owner on Aug 1, 2023. It is now read-only.
[WIP] test: add ipns dht tests #47
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned
This was referenced Nov 30, 2018
Closed
alanshaw
suggested changes
Jan 2, 2019
test/ipns.js
Outdated
| .spawn({ | ||
| disposable: true, | ||
| initOptions: { bits: 512 }, | ||
| args: ['--enable-dht-experiment'], // enable dht |
There was a problem hiding this comment.
If we release js-ipfs@0.34 with no dht enabled by default, we will need this for now.
test/ipns.js
Outdated
| it('should publish an ipns record to a go daemon and resolve it using a js daemon through the reuse of the same repo', function (done) { | ||
| this.timeout(160 * 1000) | ||
| const dir = path.join(os.tmpdir(), hat()) | ||
| describe('ipns over dht', () => { |
There was a problem hiding this comment.
These are very different tests to the repo tests above - I'd pull them out into a spearate file.
35 tasks
vasco-santos
force-pushed
the
add-ipns-dht-tests
branch
from
2766c98
to
00e3b10
Compare
|
does this also require ipfs/js-ipfs#856 @vasco-santos ? |
This should be good to go once ipfs/interop#51 is ready. The DHT PR is not needed. Just tried it out locally:
|
|
@vasco-santos would you mind rebasing for 🍏 CI please 🙏? |
vasco-santos
force-pushed
the
add-ipns-dht-tests
branch
from
00e3b10
to
60725cd
Compare
|
@alanshaw I rebased this PR and CI is green now. However, we are now dependent on ipfs/js-ipfs/pull/1994. With no experimental flag for |
vasco-santos
force-pushed
the
add-ipns-dht-tests
branch
from
60725cd
to
575036d
Compare
vasco-santos
force-pushed
the
add-ipns-dht-tests
branch
from
575036d
to
dfb3fb5
Compare
achingbrain
force-pushed
the
master
branch
3 times, most recently
from
94b26b7
to
f4c783a
Compare
achingbrain
force-pushed
the
master
branch
2 times, most recently
from
e2cb915
to
b006606
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR containing a set of tests aimimg to test the IPNS over DHT interoperability between
go-ipfsandjs-ipfs.Needs:
js-ipfs@0.35.0