-
Notifications
You must be signed in to change notification settings - Fork 15
[WIP] chore: update to ipfsd-ctl@12.0.2 #493
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@SgtPooki ipfsd-ctl@12.0.2 seems to cause tests to fail in Electron runtimes (both main and renderer):
https://github.com/ipfs/interop/runs/8236024242?check_suite_focus=true#step:5:232
This will be fixed by #462 which is almost there, just need to figure out why the go-go relay tests are timing out in CI. Obviously everything passes locally 😢 |
@lidel @achingbrain The test failures are reproducible locally with Do we still need to be testing against cjs? |
9bd71cc
to
6fb3077
Compare
Hopefully unblocked by wrapping ipfsd-ctl with a local package at test/packages/ipfsd-ctl-wrapper . At least the tests succeed locally(tested |
the electron-main bypassed the error. https://github.com/ipfs/interop/runs/8257051079?check_suite_focus=true. We should be good to go. |
No, we should be ESM only, no more dual publishing. Only forwards! |
Superseded by #462 |
No description provided.