Skip to content
This repository has been archived by the owner on Aug 1, 2023. It is now read-only.

[WIP] chore: update to ipfsd-ctl@12.0.2 #493

Closed
wants to merge 2 commits into from

Conversation

SgtPooki
Copy link
Member

@SgtPooki SgtPooki commented Sep 7, 2022

No description provided.

Copy link
Member

@lidel lidel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SgtPooki ipfsd-ctl@12.0.2 seems to cause tests to fail in Electron runtimes (both main and renderer):
https://github.com/ipfs/interop/runs/8236024242?check_suite_focus=true#step:5:232

@achingbrain
Copy link
Member

This will be fixed by #462 which is almost there, just need to figure out why the go-go relay tests are timing out in CI. Obviously everything passes locally 😢

@SgtPooki
Copy link
Member Author

SgtPooki commented Sep 8, 2022

@lidel @achingbrain The test failures are reproducible locally with npm run test -- -t electron-main --bail -f dist/cjs/node-test/*js, but updating it to npm run test -- -t electron-main --bail -f dist/esm/node-test/*js succeeds locally.

Do we still need to be testing against cjs?

@SgtPooki SgtPooki force-pushed the chore/kuboRpcClient-update-ipfsd-ctl branch from 9bd71cc to 6fb3077 Compare September 8, 2022 19:10
@SgtPooki
Copy link
Member Author

SgtPooki commented Sep 8, 2022

Hopefully unblocked by wrapping ipfsd-ctl with a local package at test/packages/ipfsd-ctl-wrapper . At least the tests succeed locally(tested npm run test -- -t electron-main --bail -f 'dist/cjs/node-test/*js' --debug -- --full-trace and npm run test -- -t electron-main --bail -f 'dist/esm/node-test/*js' --debug -- --full-trace), hopefully CI passes. Also, I updated CI to run tests against both CJS and esm

@SgtPooki
Copy link
Member Author

SgtPooki commented Sep 8, 2022

the electron-main bypassed the error. https://github.com/ipfs/interop/runs/8257051079?check_suite_focus=true. We should be good to go.

@achingbrain
Copy link
Member

Do we still need to be testing against cjs?

No, we should be ESM only, no more dual publishing. Only forwards!

@SgtPooki SgtPooki changed the title chore: update to ipfsd-ctl@12.0.2 [WIP] chore: update to ipfsd-ctl@12.0.2 Sep 9, 2022
@achingbrain
Copy link
Member

Superseded by #462

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants