This repository has been archived by the owner on Aug 1, 2023. It is now read-only.
feat: enable relay v2 tests for js-ipfs #576
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Circuit Relay v2 is being implemented in libp2p/js-libp2p#1533 so enable the tests
achingbrain
commented
Jan 18, 2023
|
|
||
| // Below are legacy tests that use js-ipfs as v1 relay | ||
| // (no tests for go-ipfs as relay v1, because since 0.11 it only supports v2) | ||
| // FIXME: remove after js-ipfs migrates to v2 |
There was a problem hiding this comment.
@lidel is this true? I still see the v1 protocol as supported by kubo@0.17.x:
% ipfs id
{
...
"AgentVersion": "kubo/0.17.0/",
"ProtocolVersion": "ipfs/0.1.0",
"Protocols": [
"/ipfs/bitswap",
"/ipfs/bitswap/1.0.0",
"/ipfs/bitswap/1.1.0",
"/ipfs/bitswap/1.2.0",
"/ipfs/id/1.0.0",
"/ipfs/id/push/1.0.0",
"/ipfs/lan/kad/1.0.0",
"/ipfs/ping/1.0.0",
"/libp2p/autonat/1.0.0",
"/libp2p/circuit/relay/0.1.0", <------ v1?
"/libp2p/circuit/relay/0.2.0/stop",
"/libp2p/dcutr",
"/p2p/id/delta/1.0.0",
"/x/"
]
}
This was referenced Jan 18, 2023
|
Circuit relay v2 tests should be run as part of libp2p interop in https://github.com/libp2p/interop Helia will have it's own interop suite which focusses more on IPFS things, so libp2p things should be tested elsewhere. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Circuit Relay v2 is being implemented in libp2p/js-libp2p#1533 - we should be able to add it with minimal changes to js-ipfs so enable the tests here to prove interop.