Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix context timout #37

Merged
merged 10 commits into from
Aug 1, 2024
Merged

fix context timout #37

merged 10 commits into from
Aug 1, 2024

Conversation

2color
Copy link
Member

@2color 2color commented Jul 29, 2024 •
edited
Loading

What's in this PR

  • chore: avoid substr in favour of modern js
  • chore: make sure connection error is distinct
  • fix: add try-catch to toggle submit on failure
  • Reuse temp libp2p host in checks to avoid creation of two temporary libp2p hosts per bitswap check
  • Add instrumentation
  • Change the check http path to /check to avoid the root / handler catching all request (including /favicon)

Depends on ipfs-shipyard/vole#43

@2color 2color requested a review from aschmahmann July 31, 2024 15:19
aschmahmann
aschmahmann reviewed Jul 31, 2024
View reviewed changes
daemon.go Show resolved Hide resolved
aschmahmann
aschmahmann reviewed Jul 31, 2024
View reviewed changes
main.go Outdated Show resolved Hide resolved
@aschmahmann aschmahmann marked this pull request as ready for review August 1, 2024 20:35
@aschmahmann aschmahmann merged commit 09f54e1 into main Aug 1, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aschmahmann aschmahmann aschmahmann left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@2color @aschmahmann