Skip to content

Commit

Permalink
Merge pull request #586 from ipfs-shipyard/fix-toggle-setting-copy
Browse files Browse the repository at this point in the history
fix: make global toggle checkbox less ambiguous
  • Loading branch information
lidel authored Sep 19, 2018
2 parents d47cc80 + 602769e commit 83f224c
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion add-on/_locales/en/messages.json
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
"description": "A label for IPFS icon (panel_headerIpfsNodeIconLabel)"
},
"panel_headerActiveToggleTitle": {
"message": "Global toggle: activate or suspend all IPFS integrations",
"message": "Global toggle: Suspend all IPFS integrations",
"description": "A label for an embedded IPFS node (panel_headerActiveToggleTitle)"
},
"panel_statusOffline": {
Expand Down
6 changes: 3 additions & 3 deletions add-on/src/options/forms/global-toggle-form.js
Original file line number Diff line number Diff line change
Expand Up @@ -5,11 +5,11 @@ const browser = require('webextension-polyfill')
const html = require('choo/html')

function globalToggleForm ({ active, onOptionChange }) {
const toggle = onOptionChange('active')
const toggle = onOptionChange('active', checked => !checked)
return html`
<form class="dib mb3">
<label for="active" class="dib pa3 pointer ${!active ? 'bg-aqua-muted br2' : ''}">
<input class="mr2 pointer" id="active" type="checkbox" onchange=${toggle} checked=${active} />
<label for="active" class="dib pa3 pointer ${!active ? 'charcoal bg-gray-muted br2' : ''}">
<input class="mr2 pointer" id="active" type="checkbox" onchange=${toggle} checked=${!active} />
${browser.i18n.getMessage('panel_headerActiveToggleTitle')}
</label>
</form>
Expand Down

0 comments on commit 83f224c

Please sign in to comment.