Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redirection toggle in popup menu #647

Closed
swedneck opened this issue Dec 26, 2018 · 17 comments · Fixed by #687
Closed

Redirection toggle in popup menu #647

swedneck opened this issue Dec 26, 2018 · 17 comments · Fixed by #687
Assignees

Comments

@swedneck
Copy link

It would be handy to be able to disable/enable redirection to the gateway quickly from the popup menu, like you can with the global toggle.

@swedneck swedneck changed the title Redirection switch in popup menu Redirection toggle in popup menu Dec 26, 2018
@lidel
Copy link
Member

lidel commented Jan 7, 2019

Hm.. one already can disable redirect via this menu item:

2019-01-08--00-01-09

I agree it is not very intuitive :) Should we rename it to something else?
Or are you suggesting moving it from menu to an icon next to the global toggle?

@lidel lidel added the status/deferred Conscious decision to pause or backlog label Jan 7, 2019
@swedneck
Copy link
Author

swedneck commented Jan 8, 2019

Yeah that's a bit unintuitive, i'd presume that public gateway simply means it will redirect any page to the public gateway rather than 127.0.0.1:8080.

I would put it next to the global toggle, although i'm not sure what icon to use.

@lidel
Copy link
Member

lidel commented Jan 9, 2019

@swedneck does any of these icons fit, or should we design a new one?

cc @olizilla for UX sanity check :)

@lidel lidel added the UX label Jan 9, 2019
@swedneck
Copy link
Author

swedneck commented Jan 9, 2019

I can't find any icon there that really feels like it fits..

image
How about something like this?

@lidel lidel added status/in-progress In progress and removed status/deferred Conscious decision to pause or backlog labels Jan 11, 2019
@swedneck
Copy link
Author

It could also work to just rename it from "Switch to (custom|public) gateway" to "(Enable|Disable) gateway redirection" and otherwise leave it as is.

@lidel
Copy link
Member

lidel commented Jan 20, 2019

Some mockups below. Would appreciate sanity check.

Text-based global redirect toggle

Enabled Disabled
on-2019-01-20--17-15-32 off-2019-01-20--17-15-55

Icon-based global redirect toggle

Alone, text may be enough, but we plan to add per-site redirect opt-out (#633) so the icon for global toggle may be a better idea:

Enabled Disabled
on-2019-01-20--22-59-30 2019-01-20--22-59-51

Having that, menu could include a single text toggle for current site:

2019-01-20--23-45-36

Thoughts? Feelings?

@swedneck
Copy link
Author

All of those look great, the last one looks perfect!

lidel added a commit that referenced this issue Jan 23, 2019
lidel added a commit that referenced this issue Feb 16, 2019
@lidel lidel mentioned this issue Feb 20, 2019
6 tasks
@ghost ghost assigned lidel Feb 20, 2019
@lidel
Copy link
Member

lidel commented Feb 20, 2019

@swedneck WIP in #687

@lidel
Copy link
Member

lidel commented Feb 26, 2019

Proposed toggle in action (from PR #687 (comment)):

redirect

This is a good time to provide feedback (or propose a better glyph) :)

@hacdias
Copy link
Member

hacdias commented Feb 26, 2019

@lidel I can't provide a better glyph right now but I don't thing it looks really good between the other two. The other are kind of circular, big, heavy. On the other hand, the middle one is just a plain icon. I'd, at least, put it into a circle to match the other two.

@lidel
Copy link
Member

lidel commented Feb 26, 2019

Cannot be unseen:
2019-02-26--14-54-36

@olizilla
Copy link
Member

I am ded 😭 🤣

@lidel
Copy link
Member

lidel commented Feb 26, 2019

For what its worth the hatboi goes away if we add another (lighter) glyph.
If it is something with similar stroke weight, things look more balanced:

We could also move the power button to the end:

2019-02-26--15-16-29

Thoughts?

@olizilla
Copy link
Member

i miss hatboi.

[redirect] [power] [settings] order wouldmake sense to me. But i think you should give hatboi a chance.

@lidel
Copy link
Member

lidel commented Feb 26, 2019

[redirect] [power] [settings]

2019-02-26--15-20-00

@lidel
Copy link
Member

lidel commented Mar 4, 2019

After some additional reviews it seems that the icon is causing more confusion than it should, and a regular menu item is more intuitive.

See update in #687 (comment)

@lidel lidel closed this as completed in #687 Mar 5, 2019
@ghost ghost removed the status/in-progress In progress label Mar 5, 2019
@lidel
Copy link
Member

lidel commented Mar 5, 2019

Ready for testing: v2.7.5.748 (Beta)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants