feat: add 'Open Web UI' button to the welcome page #769
Conversation
colinfruit
changed the title
|
Thank you @colinfruit! ❤️
Before we merge this let's get a quick UX check from @ericronne: (this screen is shown when user installs ipfs-companion for the first time and already has ipfs-desktop running in the background) |
|
For accessibility's sake, i'd go with a higher-contrast button/text combo, eg …
|
|
@colinfruit mind updating the CSS to match Eric's suggestion? |
|
UX recommendation re language - "Web UI" doesn't have meaning for IPFS
users, only for core developers.
Can we change to something descriptive like "View and manage IPFS"? Or
something like that?
…On Tue, Oct 1, 2019 at 12:22 PM Marcin Rataj ***@***.***> wrote:
@colinfruit <https://github.com/colinfruit> mind swapping the CSS to
match Eric's suggestion?
I know you tried to match the style buttons from Web UI but we need to fix
contrast there as well, so it is okay to use custom one here for now :)
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#769>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAAMHNZTE5NQOSY5LSUY32TQMN2MLANCNFSM4I3OK66Q>
.
|
|
That's a little long for a button label. |
|
@lidel, I'm happy to change the CSS to match @ericronne 's suggestions. One question, if 'Open Web UI' isn't descriptive enough for an ordinary user, shouldn't it be changed in both the browser-action drop-down and the welcome screen button? Just asking because it will change the way I go about this. I will just leave the other language's translations as they are, because I don't speak any of the available languages fluently. Is there a proper process handling translations, or anyone I should notify? I prefer 'Open Dashboard' for both, myself, and will proceed with that, barring any objections. |
|
Yes this is about more than a button label; it’s about what that browser-based thing that’s a lot like IPFS Desktop is called. It’s a branding issue. As such, I recommend that we keep “Open Web UI” as the button text for now – to unblock this PR – and continue the (important) naming chat in a new issue. |
|
OK, 'Open Web UI' it is. |
There was a problem hiding this comment.
Thank you all! Let's merge it.
-
@autonome @ericronne I've moved discussion about renaming "Open Web UI" to Changing language around Web UI #781, let's continue there
-
@ericronne Updating button style can be tracked in existing Styleguide and Language for the UI's ipfs-gui#7 (comment)
-
@colinfruit thanks again for the PR! Some info for future reference: Translation files are synced with Transifex before each release, so no need to worry about them. When it comes to translations all you need to do is to update or add keys in English locale (
add-on/_locales/en/messages.json). When merged tomasterthose new strings will be uploaded to Transifex automatically within 24h, making them available for crowdsourced translation.
Demo of the proposal in issue #763. Personally, I think that this feature should be included because it provides a quick and obvious way to open the web ui.
closes #763