Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Styleguide and Language for the UI's #7

Closed
daviddias opened this issue Dec 14, 2017 · 24 comments
Closed

Styleguide and Language for the UI's #7

daviddias opened this issue Dec 14, 2017 · 24 comments
Assignees
Labels
topic/design-visual Visual design ONLY, not part of a larger UX effort

Comments

@daviddias
Copy link
Member

@olizilla and @alanshaw brought up a ton of valuable points to the discussion, some of them were focused on the lack of Style Guide and Language.

@olizilla @alanshaw, mind sharing a recap here?

@lidel
Copy link
Member

lidel commented Jan 4, 2018

Some inspiration from Mozilla: Photon Design System

@olizilla
Copy link
Member

olizilla commented Jan 8, 2018

  • Create a ui-style-guide repo as a guide to the design language of ipfs apps.
  • Support UI experimentation, but retain a coherent feel across apps by providing a reusable color palette, type-scale, font-family, and spacing, as drop-in, atomic, css rules.
  • Provide brief explanations of how, why and where to use them.
  • Document how to add new elements. Over time this project should expand to include reusable components and ui patterns as we create them.

@akrych
Copy link

akrych commented Jan 10, 2018

@olizilla About the Design System Guidelines - Can we create together a list (a small one - first MVP) with what we need in first?

In my opinion it should be:

Logo(options and do/dont's)
Colors
Typography
Buttons
Forms
Errors and message
Iconography
Resources to download (logos, color schemes, set of icons)
When we have this list - I will design graphic elements/descriptions :)

@akrych akrych assigned akrych and unassigned akrych Jan 11, 2018
@olizilla
Copy link
Member

For sure!

My main focus on this is to make sure that that whatever the design guidelines are, that I make them easy for devs to implement, by capturing them in code and publishing it as a repo and website.

I made a start on that here: https://github.com/ipfs-shipyard/ipfs-ui-style-guide and I'd love to chat about it when you have time.

@olizilla
Copy link
Member

Also! Everything in https://github.com/ipfs-shipyard/ipfs-ui-style-guide is TBC as I haven't checked it with you yet @akrych 😄

@lidel
Copy link
Member

lidel commented Jan 14, 2018

Hi all, be sure to check (first sketch of) IPFS Brand Book Guidelines at ipfs-inactive/ipfs-ui-style-guide#3 :)

@akrych
Copy link

akrych commented Jan 19, 2018

Hello Guys,

I start working on IPFS Web GUI Kit and and I would like to show you how the work is going :)
The first thing to go: Colors, Buttons, Inputs, Selects, Dropdowns, Checkboxes, Radio buttons etc. The next will be:

  • Typography,
  • Icons(I made second set with filled shapes - when we finish I can make a font from them),
  • Labels,
  • Tabs,
  • Progress bars,
  • Tooltips,
  • Pagination,
  • Carousel,
  • Notifications,
  • Tables

You can also see it and CSS inspect on Zeplin: https://zpl.io/awyMrgj
Feel free to comment, if you want to change or add something :)

ipfs web gui kit

@lidel
Copy link
Member

lidel commented Jan 19, 2018

@akrych fantastic 👌

Small request: we probably want to extract/add info about scrollbar.
Right now it is a part of long select-list:

2018-01-19 14_46_56-35153249-fb3813a2-fd25-11e7-87ab-0b05f54a88b8 png png image 2320 x 5895 pixels

For example, @hacdias could use it in File Manager :)

@akrych
Copy link

akrych commented Jan 19, 2018

@lidel

Small request: we probably want to extract/add info about scrollbar.

sure :) 👍

@hacdias
Copy link
Member

hacdias commented Jan 19, 2018

Btw

image

I would like to be able to take the info about the border/shadow on hover/active and such 😄

@akrych
Copy link

akrych commented Jan 19, 2018

@hacdias - Sure thing:) - all parts will have the dimensions and attributes described (btw. You can se almost everything is in Zeplin now - I guess that the "focus" one have missing shadow because I made it by the "glow" not "shadow" function in Photoshop:)

@hacdias
Copy link
Member

hacdias commented Jan 19, 2018

Thanks!

@lidel
Copy link
Member

lidel commented Jan 21, 2018

Just a thought: we should consider using Github Pages for hosting things like UI Kit (after conversion to HTML page) directly from github repo. (It is possible to provide custom index.html)

@olizilla
Copy link
Member

olizilla commented Jan 21, 2018 via email

@daviddias
Copy link
Member Author

@akrych that looks HAWT 🔥 👏🏽👏🏽

Just a thought: we should consider using Github Pages for hosting things like UI Kit (after conversion to HTML page) directly from github repo. (It is possible to provide custom index.html)

👍 for simplicity, 👎 for not dogfooding our stuff. Having a publish script on merge to master should not be complicated.

@alanshaw
Copy link
Member

@akrych this is super cool! One issue I noticed - the selected radio - I was expecting a solid turquoise circle inside, I think the turquoise hoop could be misconstrued as a deselected.

@akrych
Copy link

akrych commented Jan 22, 2018

@alanshaw Sure, we can change it:)

@akrych
Copy link

akrych commented Feb 9, 2018

Next update :)
The next step is cut it for subpages and describe guidlines for them. I will also add subpage about use a logo and resource to download (logos, icons etc.)

ipfswebguikit

@akrych
Copy link

akrych commented Feb 9, 2018

Link to better quality: https://c1.staticflickr.com/5/4701/28390704879_54074deeec_o.png

@olizilla
Copy link
Member

olizilla commented Feb 9, 2018

Very nice! I made a start on css-ing the previous version over here:
https://ipfs.io/ipfs/QmW7Y6314aYnwKPJCtLv747fZ9HuixjVjkJxH6asChL3Hs/

and extracted out a minimal re-usable set of css utility classes over here:
https://github.com/ipfs-shipyard/ipfs-css

@hacdias
Copy link
Member

hacdias commented Feb 10, 2018

Hey @akrych! I really like what you've been doing 😄 I'll probably start to implement it on IPFS Desktop soon!

@malikpiara also liked it very much! He also has some suggestions: maybe use the grey color on the 'Cancel' buttons and a green color on 'Create'.

Btw, do you have it on Zeplin?

@ericronne ericronne added design topic/design-visual Visual design ONLY, not part of a larger UX effort and removed design labels May 22, 2019
@lidel
Copy link
Member

lidel commented Oct 2, 2019

Issue extracted from ipfs/ipfs-companion#769 (comment):

The default button style has low contrast, making white text in the first column hard to read:

Screenshot_2019-10-02 36040348-783d623a-0dc5-11e8-9ef8-bfb1280e26ed png (PNG Image, 1456 × 8193 pixels)

(we switched away from that style in Web UI and Companion, switching to version from the second or third column)

@jessicaschilling
Copy link
Contributor

Closing in favor of #29 (and mentioning this issue there for the sake of not losing these design sketches)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic/design-visual Visual design ONLY, not part of a larger UX effort
Projects
None yet
Development

No branches or pull requests

8 participants