Chromium duplicates recovery tab #805
Assignees
Labels
area/chromium
Issues related to Chromium-based browsers
kind/bug
A bug in existing code (including security flaws)
Comments
lidel
added
kind/bug
lidel
added a commit
that referenced
this issue
Oct 30, 2019
- listen only for webRequest.ResourceType=main_frame - reuse existing tab - deduplicate onErrorOccurred events on Chrome Closes #805
lidel
added a commit
that referenced
this issue
Oct 30, 2019
This fixes small quirks that did not break recovery, but made it bit confusing or inefficient. * fix: duplicated recovery tabs in Chromium Deduplicate `onErrorOccurred` events: sometimes Chrome produces two, possibly due to lack of async functions in webRequest APIs Closes #805 * fix: skip requests from DNS fixup logic in Firefox Firefox automatically adds 'www.' to TLD+1 names if initial DNS lookup failed. This produced bogus request+error which recovery logic is now aware of and ignores. Closes #804 * Other - make `onErrorOccurred` non-async (only Firefox supports those) - listen only for errors when `webRequest.ResourceType`=`main_frame` - reuse existing tab
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
DNS recovery was added in #800
https://bafybeiemxf5abjwjbikoz4mc3a3dla6ual3jsgpdr4cjr3oz3evfyavhwq.ipfs.dead-domain-within-ok-tld.link/fails and gets recovered by code added in #802However, when original tab (with failed request) is clicked on, recovery code is sometimes executed again, resulting in duplicated tabs for recovered content. This happens on Chromium, was unable to reproduce on Firefox.
See also #804 (both may require similar fix)
The text was updated successfully, but these errors were encountered: