fix: truncate no. of peers to unit of "k" when > 999 #1053
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
lidel
changed the title
|
sorry that my code didn't pass the test for JS lint, has fixed by using standard JS lint and pushed. Thanks for reviewing! |
Not a problem. Thanks so much for the contribution! I touched up the code a tiny bit and am giving it my approval now. |
SgtPooki
approved these changes
Jul 11, 2022
lidel
approved these changes
Sep 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1017
About
The issue opener found out that when number of peers is 1000 or above, the last digit might be partially invisible and cause confusion due to the badge's max width.
The core team replied to the issue suggesting to truncate it in the format of "1k", "2k". So I implemented the approach and made this PR.
Original UI
Committed UI Change
Show full number when < 999
This is my first PR, please let me know if I could do it better, looking forward to help with other tasks of this repo and IPFS!