Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: linkify tests #1064

Merged
merged 2 commits into from
Mar 7, 2022
Merged

fix: linkify tests #1064

merged 2 commits into from
Mar 7, 2022

Conversation

SgtPooki
Copy link
Member

@SgtPooki SgtPooki commented Mar 3, 2022

fix #1050

@SgtPooki SgtPooki requested a review from lidel as a code owner March 3, 2022 19:25
@welcome
Copy link

welcome bot commented Mar 3, 2022

Thank you for submitting this PR!
A maintainer will be here shortly to review it.
We are super grateful, but we are also overloaded! Help us by making sure that:

  • The context for this PR is clear, with relevant discussion, decisions
    and stakeholders linked/mentioned.

  • Your contribution itself is clear (code comments, self-review for the
    rest) and in its best form. Follow the code contribution
    guidelines

    if they apply.

Getting other community members to do a review would be great help too on complex PRs (you can ask in the chats/forums). If you are unsure about something, just leave us a comment.
Next steps:

  • A maintainer will triage and assign priority to this PR, commenting on
    any missing things and potentially assigning a reviewer for high
    priority items.

  • The PR gets reviews, discussed and approvals as needed.

  • The PR is merged by maintainers when it has been approved and comments addressed.

We currently aim to provide initial feedback/triaging within seven business days. Please keep an eye on any labelling actions, as these will indicate priorities and status of your contribution.
We are very grateful for your contribution!

@SgtPooki SgtPooki self-assigned this Mar 3, 2022
@SgtPooki SgtPooki added the status/in-progress In progress label Mar 3, 2022
@lidel lidel changed the title Fix should be linkified fix: linkify tests Mar 7, 2022
Copy link
Member

@lidel lidel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@lidel lidel merged commit b2bd5f2 into main Mar 7, 2022
@lidel lidel deleted the fix-should-be-linkified branch March 7, 2022 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Linkify experimental feature - demo page shows unlinked "should be linkified" text
2 participants