Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(recovery): 🐛 false-positive for non-gateway URLs #1163

Merged
merged 6 commits into from
Feb 22, 2023
Merged

fix(recovery): 🐛 false-positive for non-gateway URLs #1163

merged 6 commits into from
Feb 22, 2023

Commits on Feb 22, 2023

  1. fix(recovery): 🐛 No recovery for URLs being redirected.

    @whizzzkid
    whizzzkid committed Feb 22, 2023
    Configuration menu
    Copy the full SHA
    0d765a5 View commit details
    Browse the repository at this point in the history

  2. fix(recovery): 🧪 test added.

    @whizzzkid
    whizzzkid committed Feb 22, 2023
    Configuration menu
    Copy the full SHA
    6796c9d View commit details
    Browse the repository at this point in the history

  3. fix(recovery): 📝 Adding comments

    @whizzzkid
    whizzzkid committed Feb 22, 2023
    Configuration menu
    Copy the full SHA
    91a9567 View commit details
    Browse the repository at this point in the history

  4. fix(recovery): 🚨 linter warnings

    @whizzzkid
    whizzzkid committed Feb 22, 2023
    Configuration menu
    Copy the full SHA
    74cb934 View commit details
    Browse the repository at this point in the history

  5. fix: false-positives in sameGateway 

    This ensures sameGateway returns true only if the tested URL is
either a valid path, subdomain, or RPC URL related to local
Gateway or Kubo instance.

Everything else should be ignored, because people may run Kubo Gateway
on localhost:8080, and then stop it, and then run some unrelated HTTP
server on the same port.

This is unfortunate papercut due to the 8080 being very very popular
default port for all things HTTP. Luckily, Companion has enough
information to make this right.
    @lidel
    lidel committed Feb 22, 2023
    Configuration menu
    Copy the full SHA
    78ce18d View commit details
    Browse the repository at this point in the history

  6. test: ensure recovery does not depend on redirects

    @lidel
    lidel committed Feb 22, 2023
    Configuration menu
    Copy the full SHA
    5fd1816 View commit details
    Browse the repository at this point in the history