fix(brave): not updating tab to the new redirect url in some cases. #1285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nishant Arora <1895906+whizzzkid@users.noreply.github.com>
Signed-off-by: Nishant Arora <1895906+whizzzkid@users.noreply.github.com>
lidel
approved these changes
Sep 21, 2023
There was a problem hiding this comment.
Usually setTimeout smells fishy, but sometimes this is the only way to get UX we want, especially in Brave when there is additional IPFS code in play on the browser side that executes async (like the purple button scenario).
Retrying for half a second when there are no tabs sounds like a sane failsafe: In the past, I've experienced similar ordering discrepancies between Firefox and Chromium, and they appeared and disappeared between browser releases, so this may also help with smoothing the UX there.
lidel
reviewed
Sep 21, 2023
| originUrl: 'https://ipfs.io/ipns/en.wikipedia-on-ipfs.org', | ||
| redirectUrl: 'http://localhost:8080/ipns/en.wikipedia-on-ipfs.org' | ||
| }) | ||
| await clock.tickAsync(400) |
There was a problem hiding this comment.
nit: could we base this on MAX_RETRIES_TO_UPDATE_TAB somehow, so the reader can figure out why we sleep here?
Signed-off-by: Nishant Arora <1895906+whizzzkid@users.noreply.github.com>
This was referenced Sep 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #1283
RCA:
Demo: the double refresh is slightly visible.
Purple-loop.mov