-
Notifications
You must be signed in to change notification settings - Fork 325
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improved Automatic Mode and Options UX #277
Conversation
Node status panel now uses CSS flexbox, which produces the same look under Firefox and Chrome.
- flex-based layout that looks okay under both Firefox and Chrome - added normalization of the list of public gateways - duplicate spaces, semicolons and commas are replaced with new line when displayed in GUI (one host per line) - when stored as a property, line endings are replaced with single space
This should address UX concerns raised in #274 Text is hardcoded for now, we will move it to locale files in separate PR.
I've added a quick description for every option on the Preferences screen and made it look kinda decent under both Firefox and Chrome. Please let me know if something sounds odd or could be replaced with better label/description. |
add-on/src/options/options.html
Outdated
<label for="publicGateways"> | ||
<dl> | ||
<dt>Public Gateways</dt> | ||
<dd>list of hostnames known for exposing IPFS resources under <code>/ipfs/</code> path</dd> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Recommend rewording:
<dd>List of hostnames known to expose IPFS under <code>/ipfs/</code></dd>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🍰
add-on/src/options/options.html
Outdated
<label for="ipfsApiPollMs"> | ||
<dl> | ||
<dt>Status Poll Interval</dt> | ||
<dd>how often peer count is refreshed (in miliseconds)</dd> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
from AndyS2:
Time interval after which peer count is refreshed (in milliseconds)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe "How often peer count is refreshed" is fine, use simpler words whenever it makes sense.
add-on/src/options/options.html
Outdated
<label for="customGatewayUrl"> | ||
<dl> | ||
<dt>Custom Gateway</dt> | ||
<dd>URL address of preferred HTTP2IPFS Gateway</dd> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
from AndyS2:
dunno if 'URL address' is correct. it's either URL or web address
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed with Andy, it should probably be "URL"
add-on/src/options/options.html
Outdated
<label for="publicGateways"> | ||
<dl> | ||
<dt>Public Gateways</dt> | ||
<dd>list of hostnames known for exposing IPFS resources under <code>/ipfs/</code> path</dd> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
from AndyS2 (cake was provided via IRC):
starting everything small looks a bit weird. How about 'A list of hostnames ...' and changing everything like that?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left a few notes, otherwise looks good 👍
@@ -1,5 +1,4 @@ | |||
<html> | |||
|
|||
<!DOCTYPE html> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adding a doctype is good, but now the <html>
tag was removed! (And github doesn't escape < html > in review comments... Oops)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think its plain only in review comments.
Syntax is highlighted correctly when full file is displayed.
ps. 🍰
add-on/src/options/options.html
Outdated
<label for="ipfsApiPollMs"> | ||
<dl> | ||
<dt>Status Poll Interval</dt> | ||
<dd>how often peer count is refreshed (in miliseconds)</dd> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe "How often peer count is refreshed" is fine, use simpler words whenever it makes sense.
add-on/src/options/options.html
Outdated
<label for="customGatewayUrl"> | ||
<dl> | ||
<dt>Custom Gateway</dt> | ||
<dd>URL address of preferred HTTP2IPFS Gateway</dd> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed with Andy, it should probably be "URL"
add-on/src/options/options.html
Outdated
<label for="useCustomGateway"> | ||
<dl> | ||
<dt>Use Custom Gateway</dt> | ||
<dd>replace requests to <em>Public</em> gateway with <em>Custom</em> one</dd> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"Redirect requests made to Public gateways to the Custom gateway"
@@ -1,5 +1,4 @@ | |||
<html> | |||
|
|||
<!DOCTYPE html> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same in this file, the tag was removed
Big thanks and 🍰 for everyone! |
Automatic Mode will toggle redirect only when API state changes between online/offline.