Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds docker-build command #313

Merged
merged 5 commits into from
Nov 20, 2017
Merged

Adds docker-build command #313

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
bca3eb2
Adds docker-build command
olizilla Nov 16, 2017
4fdf130
Merge branch 'master' into docker-build
olizilla Nov 20, 2017
b9ec7d4
Use yarn.lock
olizilla Nov 20, 2017
87dfdf9
chore(yarn): same build script with/without docker
lidel Nov 20, 2017
c161f93
Merge branch 'master' into docker-build
lidel Nov 20, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ firefox
cache
build
npm-debug.log
yarn-error.log
crowdin.yml
.*~
add-on/dist
6 changes: 3 additions & 3 deletions CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,9 +58,9 @@ Each `npm` task can be run separately. The most useful ones are:

- `npm install` -- install all NPM dependencies
- `npm run build` -- build the add-on (copy external libraries, create `.zip` bundle)
- `npm test` -- run entire test suite (both unit and functional tests)
- `npm test:unit` -- run unit tests only
- `npm test:functional` -- run functional tests only
- `npm run yarn-build` -- fast install+build with yarn
- `npm run docker-build` -- reproducible build using yarn.lock and specific version of yarn and node
- `npm test` -- run entire test suite
- `npm run lint` -- check for potential syntax problems (run all linters)
- `npm run lint:standard` -- run [standard](http://standardjs.com) linter ([IPFS JavaScript projects default to standard code style](https://github.com/ipfs/community/blob/master/js-project-guidelines.md#linting--code-style))
- `npm run lint:web-ext` -- run [addons-linter](https://github.com/mozilla/addons-linter) shipped with `web-ext` tool
Expand Down
4 changes: 3 additions & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,9 @@
"postmerge": "run-s postcheckout",
"precommit": "run-s -s clean build lint",
"prepush": "run-s -s precommit test build",
"firefox": "web-ext run -s add-on/ --browser-console"
"firefox": "web-ext run -s add-on/ --browser-console",
"yarn-build": "npx yarn@1.2.1 && npx yarn@1.2.1 build",
"docker-build": "docker run -it --rm --name ipfs-companion-build -v \"$PWD\":/src -w /src node:8.9.1 /bin/bash -c \"npm run yarn-build\""
},
"private": true,
"preferGlobal": false,
Expand Down