Switch to modern Clipboard API #649
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Context: #440 (comment) This commit removes the need for content script in Firefox by switching to modern Clipboard API that landed in Firefox 63. As a result, we were able to switch copying in Chrome back to the background page, which fixed copying URLs for SVG and PDF in both browsers. Closes #440
ghost
assigned
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit removes the need for content script in Firefox by switching
to modern Clipboard API that landed in Firefox 63.
As a result, we were able to switch copying in Chrome back to the
background page, which fixed copying URLs for SVG and PDF in both
browsers.
Test URL: http://127.0.0.1:8080/ipfs/QmQyunNqiWpmgHVnTPzUy6unEwPmr6c72J1PamFpfynwmf/icons/stroke_centralization.svg (try copying its Public Gateway URL via browser action menu)