Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before, webui was bundled with extension itself. Unfortunately this
caused issues with reviews at addon (webui build was not reproducible).
This PR replaces bundled webui with one loaded from custom gateway.
from 'blessed' webuiRootUrl work without changing default go-ipfs configuration.
ipfsApi
in webui'slocalStorage
to the same endpoint as one defined in Companion (unless it was already
customized by the user).
browser.tabs.onUpdated
tobrowser.webNavigation.onDOMContentLoaded
it executes only once and in case oflinkify
experiment DOM updates are handled viaMutationObserver
anywayDigressions / notes to self:
Access-Control-Request-Headers
needs to be manually restored inAccess-Control-Allow-Headers
(Firefox allowed whitelisting cross-origin webui access without this step)Referer
header, they need to addextraHeaders
to listener's constructor. This works only in Chrome – Firefox breaks, so now one needs to provide a different arguments tobrowser.webRequest.onBeforeSendHeaders.addListener
depending on which browser is the runtime